Closed
Bug 959821
Opened 11 years ago
Closed 11 years ago
Make it painfully obvious that r= from a DOM peer is required to change test_interfaces.html
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: jst, Assigned: jst)
References
Details
Attachments
(1 file)
|
54.67 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
In order to avoid people missing the warnings about changes to test_interfaces.html needing review from a DOM peer we should make it painfully obvious that DOM peer review is required. While the current test does warn both in the header of the test and in the test failure, those warnings can easily be missed if one is modeling new API additions on changes that added existing APIs.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → jst
Summary: Make it painfully obvious that r= from a dom peer is required to change test_interfaces.html → Make it painfully obvious that r= from a DOM peer is required to change test_interfaces.html
|
|
Assignee | |
Comment 1•11 years ago
|
||
This has r=peterv in private email already.
Attachment #8360034 -
Flags: review+
|
||
Comment 2•11 years ago
|
||
Haha, this is probably the best patch that I've ever seen! :-)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Thanks :) https://hg.mozilla.org/integration/mozilla-inbound/rev/a2e041c80510
I'm pretty disappointed that we got to this point :(
|
||
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a2e041c80510
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•